-
Notifications
You must be signed in to change notification settings - Fork 58
[monarch][net] Replace tuples with named structures #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+38
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)! [ghstack-poisoned]
eliothedeman
added a commit
that referenced
this pull request
Jul 24, 2025
Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)! ghstack-source-id: 298148134 Pull Request resolved: #631
This pull request was exported from Phabricator. Differential Revision: D78846166 |
Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)! [ghstack-poisoned]
eliothedeman
added a commit
that referenced
this pull request
Jul 30, 2025
Pull Request resolved: #631 ghstack-source-id: 298317712 @exported-using-ghexport Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)!
This pull request was exported from Phabricator. Differential Revision: D78846166 |
Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)! [ghstack-poisoned]
eliothedeman
added a commit
that referenced
this pull request
Jul 31, 2025
Pull Request resolved: #631 ghstack-source-id: 299531424 @exported-using-ghexport Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)!
This pull request was exported from Phabricator. Differential Revision: D78846166 |
Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)! [ghstack-poisoned]
eliothedeman
added a commit
that referenced
this pull request
Aug 1, 2025
Pull Request resolved: #631 ghstack-source-id: 299953720 @exported-using-ghexport Differential Revision: [D78846166](https://our.internmc.facebook.com/intern/diff/D78846166/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78846166/)!
This pull request was exported from Phabricator. Differential Revision: D78846166 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 1, 2025
Summary: ghstack-source-id: 299953720 exported-using-ghexport Reviewed By: mariusae, highker, vidhyav Differential Revision: D78846166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D78846166
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!